Re: [PATCH] leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()

[Pavel Machek]

On Thu 2021-06-03 17:10:10, David Rivshin wrote:
> On Tue,  1 Jun 2021 19:09:03 +0800
> Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
> 
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'ret'.
> > 
> > Eliminate the follow smatch warning:
> > 
> > drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
> > error code 'ret'.
> > 
> > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> 
> Good catch!
> 
> Acked-by: David Rivshin <drivshin@xxxxxxxxxxx>
> 
> You might also want to add a:
> 
> Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
>

Thanks, applied. I added the fixes tag, too, but I'm not sure if this
is suitable for stable.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature