Re: [PATCH v5 1/2] mm: introduce helper to check slub_debug_enabled

From: Matthew Wilcox
Date: Sun Jul 04 2021 - 23:20:50 EST


On Mon, Jul 05, 2021 at 10:40:57AM +0800, yee.lee@xxxxxxxxxxxx wrote:
> From: Marco Elver <elver@xxxxxxxxxx>
>
> Introduce a helper to check slub_debug_enabled, so that we can confine
> the use of #ifdef to the definition of the slub_debug_enabled_unlikely()
> helper.

We don't usually embed '_unlikely' in function names; we
just do:

static inline bool slub_debug_enabled(void)
{
return static_branch_unlikely(&slub_debug_enabled);
}

eg:

static inline bool cpusets_enabled(void)
{
return static_branch_unlikely(&cpusets_enabled_key);
}

#define cgroup_bpf_enabled(type) static_branch_unlikely(&cgroup_bpf_enabled_key[type])

static inline int ip_tunnel_collect_metadata(void)
{
return static_branch_unlikely(&ip_tunnel_metadata_cnt);
}

static inline bool frontswap_enabled(void)
{
return static_branch_unlikely(&frontswap_enabled_key);
}