Re: [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring
From: Andy Shevchenko
Date: Mon Jul 05 2021 - 10:57:41 EST
On Mon, Jul 05, 2021 at 08:06:50PM +0800, Yunsheng Lin wrote:
> On 2021/7/5 17:56, Andy Shevchenko wrote:
> > On Mon, Jul 05, 2021 at 11:57:33AM +0800, Yunsheng Lin wrote:
> >> tools/include/* have a lot of abstract layer for building
> >> kernel code from userspace, so reuse or add the abstract
> >> layer in tools/include/ to build the ptr_ring for ringtest
> >> testing.
> > ...
> >> create mode 100644 tools/include/asm/cache.h
> >> create mode 100644 tools/include/asm/processor.h
> >> create mode 100644 tools/include/generated/autoconf.h
> >> create mode 100644 tools/include/linux/align.h
> >> create mode 100644 tools/include/linux/cache.h
> >> create mode 100644 tools/include/linux/slab.h
> > Maybe somebody can change this to be able to include in-tree headers directly?
> If the above works, maybe the files in tools/include/* is not
> necessary any more, just use the in-tree headers to compile
> the user space app?
> Or I missed something here?
I don't know if it works or not or why that decision had been made to
copy'n'paste headers (Yes, I know they have some modifications).
Somebody needs to check that and see what can be done in order to avoid copying
entire include into tools/include.
> > Besides above, had you tested this with `make O=...`?
> You are right, the generated/autoconf.h is in another directory
> with `make O=...`.
> Any nice idea to fix the above problem?
No idea. But I consider breakage of O= is a show stopper.
With Best Regards,