[PATCH V2] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()

From: Yu Kuai
Date: Tue Jul 06 2021 - 08:41:52 EST

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by moving the error_pm label above the pm_runtime_put() in
the error path.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
changes in V2:
- As suggested by Johan, instead of using pm_runtime_resume_and_get,
moving the 'error_pm' label above the pm_runtime_put() in the error path.

drivers/dma/sh/usb-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 8f7ceb698226..1cc06900153e 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -855,8 +855,8 @@ static int usb_dmac_probe(struct platform_device *pdev)

- pm_runtime_put(&pdev->dev);
+ pm_runtime_put(&pdev->dev);
return ret;