Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get info for PF

From: Jakub Kicinski
Date: Tue Jul 06 2021 - 19:14:36 EST


On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote:
> + return devlink_info_version_running_put(req, "fw-version", version_str);

Please use one of the existing names instead of "fw-version",
e.g. DEVLINK_INFO_VERSION_GENERIC_FW.