Re: [PATCH] ext4: Fix comments and spaces to follow coding style

From: Jan Gru
Date: Wed Jul 07 2021 - 01:25:53 EST



On 06.07.21 21:20, Theodore Ts'o wrote:
On Tue, Jul 06, 2021 at 08:39:00PM +0200, Jan Gruber wrote:
[...]
Please don't send "checkpatch.pl --file" patches for the ext4 file
system; if you must, please focus on files in the drivers directory,
where they are more welcome. If developers are making changes to a
file, fixing some checkpatch.pl whines is fine, but white-sapace only
changes just obfuscates "git blame" code archology, and so the costs
far outwieghs the costs. "Fix" is also not the right verb to use.
For more information please see [1].

[1] https://gist.github.com/17twenty/8154928

If you are looking for subtantive ways of contributing to the ext4
file system, feel free to look at various syzbot warnings[2] and try
to figure out what is going on there.

[2] https://syzkaller.appspot.com/upstream

(In some cases, the syzbot complaint has already been fixed, and it's
just a matter of letting syzbot knoww that it has since been fixed by
a particular commit. See [3] for more details.)

[3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md

Cheers,

- Ted

Thank you very much for the hints, Ted!

As a kernel newbie I was not aware, that it is undesirable to send
cleanup patches. I won't do that again.

I'm thankful for the provided resources, which look valuable to me.
In the future I will try to find and tackle syzbot-errors, as you
proposed.

Sorry for bothering you with a trivial cleanup-patch.

Best regards,
        Jan