Re: [PATCH 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config

From: Johannes Weiner
Date: Fri Jul 09 2021 - 10:49:51 EST


On Thu, Jul 08, 2021 at 05:05:09PM -0700, Suren Baghdasaryan wrote:
> Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and
> cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static
> key check inline before calling the main body of the function. This
> minimizes the memcg overhead in the pagefault and exit_mmap paths when
> memcgs are disabled using cgroup_disable=memory command-line option.
> This change results in ~1% overhead reduction when running PFT test
> comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory}
> configuration on an 8-core ARM64 Android device.
>
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>

Looks reasonable to me as well.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>