Re: [PATCH] net: qcom/emac: fix UAF in emac_remove

From: Pavel Skripkin
Date: Sat Jul 10 2021 - 02:57:39 EST


On Sat, 10 Jul 2021 00:02:26 -0500
Timur Tabi <timur@xxxxxxxxxx> wrote:

> On Fri, Jul 9, 2021 at 9:24 AM Pavel Skripkin <paskripkin@xxxxxxxxx>
> wrote:
> >
> > adpt is netdev private data and it cannot be
> > used after free_netdev() call. Using adpt after free_netdev()
> > can cause UAF bug. Fix it by moving free_netdev() at the end of the
> > function.
>
> Please spell out what "UAF" means, thanks. If you fix that, then
>
> Acked-by: Timur Tabi <timur@xxxxxxxxxx>
>
> Thanks.

Hi, Timur!

Thank you for feedback.


David has already applied this pacth. So, should I send v2 or maybe
revert + v2? I haven't been in such situations yet :)




With regards,
Pavel Skripkin