On Sun, 11 Jul 2021 02:55:02 +0000, Vincent Pelletier <plr.vincent@xxxxxxxxx> wrote:
On Sat, 10 Jul 2021 09:08:13 -0700, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
I don't immediately see where this include is needed. Is this a[...]
Are there ways to systematically tell which includes are useless
besides commenting them out all and uncommenting until it compiles ?
(if that is even a good idea)
I tried this, just to get a baseline: the module compiles with just
Beyond what you suggested this also gets rid of:
- seems reasonable:
- looks suspicious to me:
- linux/err.h, which means the error constants are indirectly
imported. Removing it feels brittle.
- linux/kernel.h, although to my surprise a lot of c files do not
By default I'll drop the former and keep the latter in the
next version, please let me know if another combination is preferred.