Re: [PATCH v4 1/4] kdb: Rename struct defcmd_set to struct kdb_macro_t

From: Doug Anderson
Date: Mon Jul 12 2021 - 09:41:20 EST


Hi,

On Mon, Jul 12, 2021 at 12:13 AM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
>
> > > @@ -671,7 +671,7 @@ static int kdb_exec_defcmd(int argc, const char **argv);
> > >
> > > static int kdb_defcmd2(const char *cmdstr, const char *argv0)
> > > {
> > > - struct defcmd_set *s = defcmd_set + defcmd_set_count - 1;
> > > + struct kdb_macro_t *s = kdb_macro + kdb_macro_count - 1;
> >
> > I guess the variable "s" was short for "set". Should it change to "m"
> > ? Here and in other places below.
> >
>
> This variable is dropped in patch #3. Can we bear this variable name
> until that patch?

Sure.

-Doug