Re: [PATCH] spi: spi-geni-qcom: Remove confusing comment about setting the watermark

From: Vinod Koul
Date: Wed Jul 14 2021 - 06:14:42 EST


On 12-07-21, 08:50, Douglas Anderson wrote:
> The comment in setup_fifo_xfer() about setting the watermark wasn't
> quite proper grammar and also stopped making sense around commit
> 6d66507d9b55 ("spi: spi-geni-qcom: Don't wait to start 1st transfer if
> transmitting"). After that commit we actually start the transfer
> _before_ the watermark interrupt comes.
>
> I don't think the comment really has any value anymore. We've already
> got a comment when we grab the spinlock saying that our interrupt can
> come any time as a result of the things in the locked section. Let's
> just remove it.

Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>

--
~Vinod