Re: [PATCH v6 2/2] ASoC: sun50i-dmic: dt-bindings: add DT bindings for DMIC controller

From: Maxime Ripard
Date: Thu Jul 15 2021 - 03:50:05 EST


On Sun, Jul 11, 2021 at 08:48:26AM -0400, fengzheng923@xxxxxxxxx wrote:
> From: Ban Tao <fengzheng923@xxxxxxxxx>
>
> DT binding documentation for this new ASoC driver.
>
> Signed-off-by: Ban Tao <fengzheng923@xxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Maxime Ripard <maxime@xxxxxxxxxx>

> ---
> v1->v2:
> 1.Fix some build errors.
> ---
> v2->v3:
> 1.Fix some build errors.
> ---
> v3->v4:
> 1.None.
> ---
> v4->v5:
> 1.Add interrupt.
> 2.Keep clock and reset index.
> ---
> v5->v6:
> 1.None.
> ---

Just as a general comment, you don't need to duplicate the --- all the
time, here something like the following would have been fine

---

v1->v2:
1.Fix some build errors.

v2->v3:
1.Fix some build errors.

v3->v4:
1.None

etc.

git will ignore anything after ---, so it doesn't matter whether there's
one or multiple.

Maxime