Re: [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support

From: Lee Jones
Date: Fri Jul 16 2021 - 05:20:21 EST


On Fri, 02 Jul 2021, Matthias Schiffer wrote:

> Updated patch series:
>
> - A number of new patches (more hardware support and a few fixes)
> - Patches 1-3 have gained Fixes tags
> - Patch 2 depends on 1, so maybe we can push the GPIO patch through the
> MFD tree to keep them together?
> - The change in patch 7 was somewhat controversial. I've added a
> warning, but it is the last patch of the series, so it doesn't affect
> the rest of the series if it is rejected.
>
>
> Matthias Schiffer (7):
> gpio: tqmx86: really make IRQ optional
> mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
> mfd: tqmx86: remove incorrect TQMx90UC board ID
> mfd: tqmx86: fix typo in "platform"
> mfd: tqmx86: add support for TQMx110EB and TQMxE40x
> mfd: tqmx86: add support for TQ-Systems DMI IDs
> mfd: tqmx86: assume 24MHz LPC clock for unknown boards
>
> drivers/gpio/gpio-tqmx86.c | 6 ++---
> drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++--------
> 2 files changed, 41 insertions(+), 13 deletions(-)

Patches look good.

Could you please collect up Andrew's acks, remove the suggested Fixes:
lines and resubmit please?

I'll quickly apply them once resent (probably Monday - if you get them
out today).

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog