Re: [PATCH v2] rtw88: Fix out-of-bounds write

From: Greg KH
Date: Fri Jul 16 2021 - 13:22:00 EST

On Fri, Jul 16, 2021 at 05:53:11PM +0200, Len Baker wrote:
> In the rtw_pci_init_rx_ring function the "if (len > TRX_BD_IDX_MASK)"
> statement guarantees that len is less than or equal to GENMASK(11, 0) or
> in other words that len is less than or equal to 4095. However the
> rx_ring->buf has a size of RTK_MAX_RX_DESC_NUM (defined as 512). This
> way it is possible an out-of-bounds write in the for statement due to
> the i variable can exceed the rx_ring->buff size.
> However, this overflow never happens due to the rtw_pci_init_rx_ring is
> only ever called with a fixed constant of RTK_MAX_RX_DESC_NUM. But it is
> better to be defensive in this case and add a new check to avoid
> overflows if this function is called in a future with a value greater
> than 512.

If this can never happen, then no, this is not needed. Why would you
check twice for the same thing?


greg k-h