Re: [PATCH V1 2/2] mmc: sdhci-msm: Use maximum possible data timeout value
From: Bjorn Andersson
Date: Fri Jul 16 2021 - 19:55:14 EST
On Fri 16 Jul 09:03 CDT 2021, Sarthak Garg wrote:
> The Qcom SD controller defines the usage of 0xF in data
> timeout counter register (0x2E) which is actually a reserved
> bit as per specification. This would result in maximum of 21.26 secs
> timeout value.
> Some SDcard taking more time than 2.67secs (timeout value corresponding
> to 0xE) and with that observed data timeout errors.
> So increasing the timeout value to max possible timeout.
> Signed-off-by: Sahitya Tummala <stummala@xxxxxxxxxxxxxx>
The From: of the email says you wrote the patch, but the first person to
certify its origin is Sahitya. Did you perhaps write this together? If
so you should have a:
If Sahitya wrote the patch, certifies its origin and then you picks it
up and certify that you got it from Sahitya, then you should write it as
you did - but you should have retained Sahitya as author...
> Signed-off-by: Sarthak Garg <sartgarg@xxxxxxxxxxxxxx>
> drivers/mmc/host/sdhci-msm.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index e44b7a6..19e4673 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -2696,6 +2696,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> msm_host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY | MMC_CAP_NEED_RSP_BUSY;
> + /* Set the timeout value to max possible */
> + host->max_timeout_count = 0xF;