Re: [PATCH] PCI: endpoint: Use sysfs_emit() in "show" functions

From: Krzysztof Wilczyński
Date: Sun Jul 18 2021 - 23:43:19 EST


Hello Hayashi-san,

Thank you for sending the patch over!

> Convert sprintf() in sysfs "show" functions to sysfs_emit() in order to
> check for buffer overruns in sysfs outputs.

Nice catch!

A small nitpick: what you are changing here are technically not sysfs
objects since all of these are related to configfs. Having said that,
configfs shares the same semantics for normal attributes with sysfs, so
a maximum size of PAGE_SIZE applies here too, and thus sysfs_emit()
would work fine.

Thank you for taking care of this!

Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx>

Krzysztof