Re: [PATCH 2/7] mm: introduce pte_install() helper

[Qi Zheng]

On 7/19/21 5:31 AM, Kirill A. Shutemov wrote:
> On Sun, Jul 18, 2021 at 12:30:28PM +0800, Qi Zheng wrote:
> > Currently we have three times the same few lines repeated in the
> > code. Deduplicate them by newly introduced pte_install() helper.
> >
> > Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
>
> I don't like the name of the helper: we have confusion of PTE being
> PTE-entry or PTE page table. And pte_install() doing pmd_populate()
> doesn't help the situation.
>
> Maybe pmd_install()? Or pte_table_install()? I donno.

Look good to me, I will use pmd_install().