Re: [PATCH] dt-bindings: mtd: spi-nand: Convert to DT schema format

From: Nandan, Apurva
Date: Tue Jul 20 2021 - 10:28:10 EST




On 19-Jul-21 7:17 PM, Rob Herring wrote:
> On Sun, 18 Jul 2021 00:41:25 +0000, Apurva Nandan wrote:
>> Convert spi-nand.txt binding to YAML format with an added example.
>>
>> Signed-off-by: Apurva Nandan <a-nandan@xxxxxx>
>> ---
>> .../devicetree/bindings/mtd/spi-nand.txt | 5 --
>> .../devicetree/bindings/mtd/spi-nand.yaml | 74 +++++++++++++++++++
>> 2 files changed, 74 insertions(+), 5 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
>> create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml: spi-flash@1: $nodename:0: 'spi-flash@1' does not match '^flash(@.*)?$'

I propose to change the nodename in snps,dw-apb-ssi.yaml from
'spi-flash@1' to 'flash@1', making it similar to the convention followed
by jedec,spi-nor.yaml. Currently, there is no user of snps,dw-apb-ssi
with a spi-nand as child node, so let's make the node name uniform
across different types of flashes i.e. 'flash@*'. What do you suggest?

> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/spi-nand.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml: spi-flash@1: 'rx-sample-delay-ns' does not match any of the regexes: '^otp(-[0-9]+)?$', '^partition@', 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/spi-nand.yaml
> \ndoc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1506558
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

Yes, yamllint was not installed. I will correct them and send as v2.

Thanks,
Apurva Nandan