Re: [for-next][PATCH 19/24] tracing: Add LATENCY_FS_NOTIFY to define if latency_fsnotify() is defined

From: Arnd Bergmann
Date: Tue Jul 20 2021 - 15:20:37 EST


On Sat, Jun 26, 2021 at 3:10 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
>
> With the coming addition of the osnoise tracer, the configs needed to
> include the latency_fsnotify() has become more complex, and to keep the
> declaration in the header file the same as in the C file, just have the
> logic needed to define it in one place, and that defines LATENCY_FS_NOTIFY
> which will be used in the C code.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

This still doesn't seem quite right. I just came across this randconfig build
warning on 5.14-rc2:

kernel/trace/trace.c:1712:13: error: 'trace_create_maxlat_file'
defined but not used [-Werror=unused-function]
1712 | static void trace_create_maxlat_file(struct trace_array *tr,

See https://pastebin.com/raw/b3DH7hWg for the .config that triggered it.

Arnd