Re: [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage

From: Leon Romanovsky
Date: Wed Jul 21 2021 - 02:57:12 EST


On Wed, Jul 21, 2021 at 07:41:12AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 09:13:02AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@xxxxxxxxxx>
> >
> > The ib_create_named_qp() is kernel verb that is not used for user
> > supplied attributes. In such case, it is ULP responsibility to provide
> > valid QP attributes.
> >
> > In-kernel API shouldn't check it, exactly like other functions that
> > don't check device capabilities.
>
> Hmm. These still looks like useful debugging checks.

All in-tree ULPs already set properly based on device capabilities.

Thanks