Re: [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu"

From: Tom Zanussi
Date: Wed Jul 21 2021 - 16:19:10 EST


Hi Steve,

On Wed, 2021-07-21 at 11:00 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
>
> Currently the histogram logic allows the user to write "cpu" in as an
> event field, and it will record the CPU that the event happened on.
>
> The problem with this is that there's a lot of events that have "cpu"
> as a real field, and using "cpu" as the CPU it ran on, makes it
> impossible to run histograms on the "cpu" field of events.
>

Yes, you're absolutely right, it should have been named "common_cpu"
from the start, not only for this reason but also just for the sake of
consistency.

Reviewed-by: Tom Zanussi <zanussi@xxxxxxxxxx>