Re: [PATCH rdma-next 8/9] RDMA: Globally allocate and release QP memory

From: Wenpeng Liang
Date: Thu Jul 22 2021 - 04:09:24 EST




On 2021/7/18 20:00, Leon Romanovsky wrote:
> + qp = rdma_zalloc_drv_obj_numa(dev, ib_qp);
> + if (!qp)
> + return ERR_PTR(-ENOMEM);
>
> qp->device = dev;
> qp->pd = pd;
> @@ -337,14 +338,11 @@ _ib_create_qp(struct ib_device *dev, struct ib_pd *pd,
>
> qp->qp_type = attr->qp_type;
> qp->rwq_ind_tbl = attr->rwq_ind_tbl;
> - qp->send_cq = attr->send_cq;
> - qp->recv_cq = attr->recv_cq;
> qp->srq = attr->srq;
> qp->rwq_ind_tbl = attr->rwq_ind_tbl;

Hi, Leon, "qp->rwq_ind_tbl = attr->rwq_ind_tbl;" seems to be duplicate,
would you consider deleting one of them in this patchset?