Re: [PATCH] misc: powermate: update the reference count of the usb interface structure

From: Salah Triki
Date: Sat Jul 24 2021 - 19:57:08 EST


Hi,

On Sat, Jul 24, 2021 at 04:08:02PM -0700, Dmitry Torokhov wrote:
>
> On Sat, Jul 24, 2021 at 10:20:16PM +0100, Salah Triki wrote:
> > Use usb_get_intf() and usb_put_intf() in order to update the reference
> > count of the usb interface structure.
>
> This is quite pointless as the driver will be unbound from the interface
> before interface is deleted.

>From the documentation of usb_get_intf():

[quote]

Each live reference to a interface must be refcounted.

Drivers for USB interfaces should normally record such references in their
probe() methods, when they bind to an interface, and release them by calling
usb_put_intf(), in their disconnect() methods.

[/quote]

Thanx