Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set()

From: Leon Romanovsky
Date: Sun Jul 25 2021 - 06:10:57 EST


On Thu, Jul 22, 2021 at 05:58:16PM +0800, Jiapeng Chong wrote:
> The return value is missing in this code scenario, add the return value
> '0' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083
> mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> -For the follow advice: https://lore.kernel.org/patchwork/patch/1461601/
>
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>