Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties

From: Neil Armstrong
Date: Mon Jul 26 2021 - 04:06:10 EST


Hi,

On 08/07/2021 14:58, Martin Blumenstingl wrote:
> On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
>>
>> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I think there's a typo here: observer -> observe
> maybe Kevin or Neil can fix this up (in this and the following two
> patches) while applying the patch so you don't have to re-spin a v3

Fixed while applying !

>
>> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
>> instead of dummy regulator.
>>
>> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
>> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
>> [ 7.117184] VCCK: supplied by regulator-dummy
>> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
>> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
>> [ 7.118498] VDDEE: will resolve supply early: pwm
>> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
>> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
>> [ 7.118553] VDDEE: supplied by regulator-dummy
>> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>>
>> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
>> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>>
>> Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>> Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>

Neil