Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

From: Viresh Kumar
Date: Mon Jul 26 2021 - 05:21:07 EST


On 26-07-21, 10:11, Arnd Bergmann wrote:
> On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> >
> > On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > >
> > > This patch adds binding for virtio I2C device, it is based on
> > > virtio-device bindings.
> > >
> > > Acked-by: Wolfram Sang <wsa@xxxxxxxxxx>
> > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> >
> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Too quick, after seeing the same issue in the gpio binding I saw it here too:
>
> > + i2c-virtio {
> > + compatible = "virtio,22";
>
> The node name "i2c-virtio" looks wrong. According to
> https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml,
> this needs to be plain "i2c".

Okay, I will move back to simple node names then.

Thanks.

--
viresh