Re: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c

From: Greg KH
Date: Mon Jul 26 2021 - 07:14:14 EST

On Mon, Jul 26, 2021 at 11:09:06AM +0000, Hayes Wang wrote:
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Monday, July 26, 2021 4:37 PM
> [...]
> > You also do other things, like renaming defines, which is not just
> > moving code around, right?
> Yes. You are right.

So resend the series and only do "one thing per patch" please.

> [...]
> > I do not know, is it really easier to find things in 3 different files
> > instead of one? That's up to you, but you did not say why this change
> > is needed.
> We support a new chip or feature with a test driver.
> The test driver is similar with the upstream driver, except
> the method of the firmware. After we confirm that the
> test driver work fine, we compare the differences with
> the upstream driver and submit patches. And the code
> about firmware takes us more time to find out the
> differences. Therefore, I wish to move the part of
> the firmware out.

Great, then submit the broken up driver as part of a patchset that adds
new device support, as that makes more sense when that happens, right?


greg k-h