Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types

From: Robin Murphy
Date: Mon Jul 26 2021 - 09:09:12 EST

On 2021-07-26 13:46, Joerg Roedel wrote:
On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote:
- if (type == IOMMU_DOMAIN_DMA && using_legacy_binding)
+ if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding)

Hmm, I wonder whether it is time to introduce helpers for these checks?

Something like iommu_domain_is_dma() is more readable.

Ha, I had exactly that at one point, except I think in the order of iommu_is_dma_domain() :)

The end result didn't seem to give enough extra clarity to justify the header churn for me, but I'm happy to be wrong about that if you prefer.