Re: [PATCH v2 2/2] pinctrl: single: Move test PCS_HAS_PINCONF in pcs_parse_bits_in_pinctrl_entry() to the beginning
From: Tony Lindgren
Date: Tue Jul 27 2021 - 05:56:35 EST
* Zhen Lei <thunder.leizhen@xxxxxxxxxx> [210722 03:40]:
> The value of pcs->flags is not overwritten in function
> pcs_parse_bits_in_pinctrl_entry() and its subfunctions, so moving this
> check to the beginning of the function eliminates unnecessary rollback
> operations.
Looks OK to me:
Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx>