Re: [PATCH v5 1/3] docs: ext-ctrls-codec: Document cyclic intra-refresh zero control value

From: Hans Verkuil
Date: Wed Jul 28 2021 - 06:11:40 EST


On 22/06/2021 13:39, Stanimir Varbanov wrote:
> In all drivers _CYCLIC_INTRA_REFRESH_MB default control value is zero
> which means that the macroblocks will not be intra-refreshed. Document
> this _CYCLIC_INTRA_REFRESH_MB control behaviour in control description.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Thanks!

Hans

> ---
> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> index 8c6e2a11ed95..addf44b99dfa 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> @@ -1174,7 +1174,9 @@ enum v4l2_mpeg_video_h264_entropy_mode -
> Cyclic intra macroblock refresh. This is the number of continuous
> macroblocks refreshed every frame. Each frame a successive set of
> macroblocks is refreshed until the cycle completes and starts from
> - the top of the frame. Applicable to H264, H263 and MPEG4 encoder.
> + the top of the frame. Setting this control to zero means that
> + macroblocks will not be refreshed.
> + Applicable to H264, H263 and MPEG4 encoder.
>
> ``V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE (boolean)``
> Frame level rate control enable. If this control is disabled then
>