Re: [PATCH] memcg: cleanup racy sum avoidance code

From: Andrew Morton
Date: Wed Jul 28 2021 - 15:43:32 EST


On Tue, 27 Jul 2021 18:22:43 -0700 Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:

> We used to have per-cpu memcg and lruvec stats and the readers have to
> traverse and sum the stats from each cpu. This summing was racy and may
> expose transient negative values. So, an explicit check was added to
> avoid such scenarios. Now these stats are moved to rstat infrastructure
> and are no more per-cpu, so we can remove the fixup for transient
> negative values.

We can't do anything about the same code in lruvec_page_state_local()?