Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default

[Ojaswin Mujoo]

On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote:
> On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote:
> > Before this config was defined, the cdev used to be created
> > unconditionally. When an earlier commit introduced this config, the
> > default behavior was set to disabled, which might surprise some
> > unsuspecting users.  Hence, make this config default to 'Y' to be more
> > backward consistent.
> > 
> > Signed-off-by: Ojaswin Mujoo <ojaswin98@xxxxxxxxx>
> > ---
> >  drivers/staging/vc04_services/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> > index 63caa6818d37..2b70c37cdd09 100644
> > --- a/drivers/staging/vc04_services/Kconfig
> > +++ b/drivers/staging/vc04_services/Kconfig
> > @@ -23,6 +23,7 @@ if BCM2835_VCHIQ
> >  
> >  config VCHIQ_CDEV
> >  	bool "VCHIQ Character Driver"
> > +	default y
> 
> 
> default y is only if the machine will not work without this option.
> Is that the case here?  If not, then please do not have this as the
> default.
Got it Greg. 

>From my testing, the Raspberry Pi does seem to boot correctly without
this although some userspace libraries might not work. 

Since the machine itself works, I guess I'll drop this patch.

Thank you!
Ojaswin
> 
> thanks,
> 
> greg k-h