Re: [PATCH] crypto: ccp: shutdown SEV firmware on kexec

From: Tom Lendacky
Date: Wed Jul 28 2021 - 16:41:07 EST


On 7/28/21 10:15 AM, Brijesh Singh wrote:
> The commit 97f9ac3db6612 ("crypto: ccp - Add support for SEV-ES to the
> PSP driver") added support to allocate Trusted Memory Region (TMR)
> used during the SEV-ES firmware initialization. The TMR gets locked
> during the firmware initialization and unlocked during the shutdown.
> While the TMR is locked, access to it is disallowed.
>
> Currently, the CCP driver does not shutdown the firmware during the
> kexec reboot, leaving the TMR memory locked.
>
> Register a callback to shutdown the SEV firmware on the kexec boot.
>
> Fixes: 97f9ac3db6612 ("crypto: ccp - Add support for SEV-ES to the PSP driver")
> Reported-by: Lucas Nussbaum <lucas.nussbaum@xxxxxxxx>
> Tested-by: Lucas Nussbaum <lucas.nussbaum@xxxxxxxx>
> Cc: <stable@xxxxxxxxxx>
> Cc: Tom Lendacky <thomas.lendacky@xxxxxxx>
> Cc: Joerg Roedel <jroedel@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>

Acked-by: Tom Lendacky <thomas.lendacky@xxxxxxxxx>

> ---
> drivers/crypto/ccp/sev-dev.c | 49 +++++++++++++++++-------------------
> drivers/crypto/ccp/sp-pci.c | 12 +++++++++
> 2 files changed, 35 insertions(+), 26 deletions(-)
>