Re: [PATCH] tablet: acecad: update the reference count of the usb interface structure

From: Dan Carpenter
Date: Thu Jul 29 2021 - 04:32:46 EST

On Thu, Jul 29, 2021 at 01:54:27AM +0100, Salah Triki wrote:
> On Tue, Jul 27, 2021 at 03:37:56PM +0300, Dan Carpenter wrote:
> > This commit message doesn't say what the user visible effects are. If
> > you encountered this bug at runtime then please put the stack trace in
> > the commit mesage.
> >
> I made this patch based on the following documentation of
> usb_get_intf():
> [quote]
> Each live reference to a interface must be refcounted.
> Drivers for USB interfaces should normally record such references
> in their probe methods, when they bind to an interface, and release them
> by calling usb_put_intf, in their disconnect methods.
> [/quote]

Put that information in the commit message. Otherwise to review this
patch then I'm trying to look through the syzbot dashboard to find the
stack trace.

dan carpenter