Re: [RFC-PATCH] net: stmmac: Add KR port support.

[Florian Fainelli]

On 7/29/21 4:44 PM, Daniel Walker wrote:
> From: Balamurugan Selvarajan <balamsel@xxxxxxxxx>
> 
> For KR port the mii interface is a chip-to-chip
> interface without a mechanical connector. So PHY
> inits are not applicable. In this case MAC is
> configured to operate at forced speed(1000Mbps)
> and full duplex. Modified driver to accommodate
> PHY and NON-PHY mode.
> 
> Cc: xe-linux-external@xxxxxxxxx
> Signed-off-by: Balamurugan Selvarajan <balamsel@xxxxxxxxx>
> Signed-off-by: Daniel Walker <danielwa@xxxxxxxxx>

You are not adding KR support per-se, you are just hacking the driver so
it is happy with an unspecified phy_interface_t value and assuming
1000Mbits/sec, this is not going to work.

Just add KR/backplane properly or use a fixed-link property hardcoded
for 1000Mbits/sec and be done with it with no hacking, which would be
just way better than what is proposed here.
-- 
Florian