Re: [PATCH 4/4] arm: dts: zynq: Replace 'io-standard' with 'power-source' property

From: Linus Walleij
Date: Fri Jul 30 2021 - 08:46:58 EST


On Thu, Jul 29, 2021 at 9:59 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Wed, Jul 21, 2021 at 05:22:33PM +0530, Sai Krishna Potthuri wrote:
> > Replace 'io-standard' property with 'power-source' property in all zynq dts
> > files to be in sync with Zynq pinctrl driver.
> >
> > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/zynq-ebaz4205.dts | 8 ++++----
> > arch/arm/boot/dts/zynq-microzed.dts | 2 +-
> > arch/arm/boot/dts/zynq-zc702.dts | 20 ++++++++++----------
> > arch/arm/boot/dts/zynq-zc706.dts | 18 +++++++++---------
> > 4 files changed, 24 insertions(+), 24 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/zynq-ebaz4205.dts b/arch/arm/boot/dts/zynq-ebaz4205.dts
> > index b0b836aedd76..be7eae611fb7 100644
> > --- a/arch/arm/boot/dts/zynq-ebaz4205.dts
> > +++ b/arch/arm/boot/dts/zynq-ebaz4205.dts
> > @@ -57,7 +57,7 @@
> >
> > conf {
> > groups = "gpio0_20_grp", "gpio0_32_grp";
> > - io-standard = <3>;
> > + power-source = <3>;
>
> This will break using a new DT with a kernel without patch 3.

The old (Linux) kernel never supported the "io-standard" property
anyway.

Unless someone is running som BSD or Windows with support for
this property it can be merged by the quality of zero real-world
impacts (no-one there to hear the tree fall in the forest).

Sai Krishna: correct?

Yours,
Linus Walleij