Re: [PATCH v1 0/5] cpuidle: teo: Rework the idle state selection logic

From: Rafael J. Wysocki
Date: Fri Jul 30 2021 - 09:25:34 EST


On Fri, Jul 30, 2021 at 5:36 AM Doug Smythies <dsmythies@xxxxxxxxx> wrote:
>
> On Thu, Jul 29, 2021 at 9:14 AM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> >
> ... [snip]...
> >
> > This means that idle state 0 data are disregarded after disabling it
> > and that most likely is because the second loop in teo_select() should
> > be over all states down to idle state 0 (not only down to the first
> > enabled one).
> >
> > So below is an updated patch (not tested yet).
>
> Hi Rafael,
>
> This updated patch works great / solves the problem.
> Tested-by: Doug Smythies <dsmythies@xxxxxxxxx>
>
> Thank you very much.

Thank you and you're welcome!

I've found a small issue in the patch though (it needs to check the
time span before setting the "last enabled" index), so let me submit a
proper patch with a changelog based on this one.