Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update

From: Greg KH
Date: Sat Jul 31 2021 - 04:05:10 EST


On Sat, Jul 31, 2021 at 10:53:28AM +0300, Kalle Valo wrote:
> Greg KH <greg@xxxxxxxxx> writes:
>
> > On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
> >> When we exceed the limit of BSS entries, this function will free the
> >> new entry, however, at this time, it is the last door to access the
> >> inputed ies, so these ies will be unreferenced objects and cause memory
> >> leak.
> >> Therefore we should free its ies before deallocating the new entry, beside
> >> of dropping it from hidden_list.
> >>
> >> Signed-off-by: Nguyen Dinh Phi <phind.uet@xxxxxxxxx>
>
> [...]
>
> > Did this change get lost somewhere?
>
> Johannes applied it to the macc80211 tree:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
>
> Ah, and it's already in Linus' tree as well.

Ah, thanks, I had missed that it just landed there.

greg k-h