Re: [PATCH] mt76: fix enum type mismatch

From: Kalle Valo
Date: Sat Jul 31 2021 - 04:39:01 EST


Arnd Bergmann <arnd@xxxxxxxxxx> writes:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> There is no 'NONE' version of 'enum mcu_cipher_type', and returning
> 'MT_CIPHER_NONE' causes a warning:
>
> drivers/net/wireless/mediatek/mt76/mt7921/mcu.c: In function 'mt7921_mcu_get_cipher':
> drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:114:24: error: implicit conversion from 'enum mt76_cipher_type' to 'enum mcu_cipher_type' [-Werror=enum-conversion]
> 114 | return MT_CIPHER_NONE;
> | ^~~~~~~~~~~~~~
>
> Add the missing MCU_CIPHER_NONE defintion that fits in here with
> the same value.
>
> Fixes: c368362c36d3 ("mt76: fix iv and CCMP header insertion")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> This problem currently exists in 5.14-rc2, please ignore my patch
> if a fix is already queued up elsewhere.

Should I take this to wireless-drivers? Felix, ack?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches