Re: [PATCH v3] nfc: hci: pass callback data param as pointer in nci_request()
Date: Mon Aug 02 2021 - 10:20:35 EST
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 31 Jul 2021 12:21:44 +0200 you wrote:
> The nci_request() receives a callback function and unsigned long data
> argument "opt" which is passed to the callback. Almost all of the
> nci_request() callers pass pointer to a stack variable as data argument.
> Only few pass scalar value (e.g. u8).
> All such callbacks do not modify passed data argument and in previous
> commit they were made as const. However passing pointers via unsigned
> long removes the const annotation. The callback could simply cast
> unsigned long to a pointer to writeable memory.
Here is the summary with links:
- [v3] nfc: hci: pass callback data param as pointer in nci_request()
You are awesome, thank you!
Deet-doot-dot, I am a bot.