Re: [PATCH v3] thunderbolt: For dev authorization changes, include the actual event in udev change notification

From: Mika Westerberg
Date: Mon Aug 02 2021 - 11:07:56 EST


Hi Rajat,

On Fri, Jul 30, 2021 at 04:53:04PM -0700, Rajat Jain wrote:
> For security, we would like to monitor and track when the thunderbolt
> devices are authorized and deauthorized (i.e. when the thunderbolt sysfs
> "authorized" attribute changes). Currently the userspace gets a udev
> change notification when there is a change, but the state may have
> changed (again) by the time we look at the authorized attribute in
> sysfs. So an authorization event may go unnoticed. Thus make it easier
> by informing the actual change (new value of authorized attribute) in
> the udev change notification.
>
> The change is included as a key value "authorized=<val>" where <val>
> is the new value of sysfs attribute "authorized", and is described at
> Documentation/ABI/testing/sysfs-bus-thunderbolt under
> /sys/bus/thunderbolt/devices/.../authorized
>
> Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx>

I did some tiny changes to the title, commit message and the comment and
applied to thunderbolt.git/next, thanks!