Re: [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint()

From: Nitesh Lal
Date: Mon Aug 02 2021 - 11:26:57 EST


On Tue, Jul 20, 2021 at 7:26 PM Nitesh Narayan Lal <nitesh@xxxxxxxxxx> wrote:
>
> The drivers currently rely on irq_set_affinity_hint() to either set the
> affinity_hint that is consumed by the userspace and/or to enforce a custom
> affinity.
>
> irq_set_affinity_hint() as the name suggests is originally introduced to
> only set the affinity_hint to help the userspace in guiding the interrupts
> and not the affinity itself. However, since the commit
>
> e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"
>

[...]

> drivers/infiniband/hw/irdma/hw.c | 4 +-
> drivers/mailbox/bcm-flexrm-mailbox.c | 4 +-
> drivers/net/ethernet/cisco/enic/enic_main.c | 8 +--
> drivers/net/ethernet/emulex/benet/be_main.c | 4 +-
> drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 +-
> drivers/net/ethernet/intel/i40e/i40e_main.c | 8 +--
> drivers/net/ethernet/intel/iavf/iavf_main.c | 8 +--
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++--
> drivers/net/ethernet/mellanox/mlx4/eq.c | 8 ++-
> .../net/ethernet/mellanox/mlx5/core/pci_irq.c | 8 +--
> drivers/scsi/lpfc/lpfc_init.c | 4 +-
> drivers/scsi/megaraid/megaraid_sas_base.c | 27 +++++-----
> drivers/scsi/mpt3sas/mpt3sas_base.c | 21 ++++----
> include/linux/interrupt.h | 53 ++++++++++++++++++-
> kernel/irq/manage.c | 8 +--
> 15 files changed, 114 insertions(+), 65 deletions(-)
>
> --
>
>

Gentle ping.
Any comments on the following patches:

genirq: Provide new interfaces for affinity hints
scsi: megaraid_sas: Use irq_set_affinity_and_hint
scsi: mpt3sas: Use irq_set_affinity_and_hint
enic: Use irq_update_affinity_hint
be2net: Use irq_update_affinity_hint
mailbox: Use irq_update_affinity_hint
hinic: Use irq_set_affinity_and_hint

or any other patches?

--
Thanks
Nitesh