Re: [PATCH net-next 1/2] net/sched: sch_ingress: Support clsact egress mini-Qdisc option

From: Cong Wang
Date: Mon Aug 02 2021 - 20:09:48 EST


On Mon, Aug 2, 2021 at 2:11 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
>
> NAK, just use clsact qdisc in the first place which has both ingress and egress
> support instead of adding such hack. You already need to change your scripts for
> clsact-on, so just swap 'tc qdisc add dev eth0 ingress' to 'tc qdisc add dev eth0
> clsact' w/o needing to change kernel.

If we were able to change the "script" as easily as you described,
you would not even see such a patch. The fact is it is not under
our control, the most we can do is change the qdisc after it is
created by the "script", ideally without interfering its traffic,
hence we have such a patch.

(BTW, it is actually not a script, it is a cloud platform.)

Thanks.