Re: [PATCH v2] staging: r8188eu: core: Change the length of an array

From: Dan Carpenter
Date: Tue Aug 03 2021 - 02:17:10 EST


On Mon, Aug 02, 2021 at 10:30:20PM +0200, Fabio M. De Francesco wrote:
> IPX_NODE_LEN == 6, while addr.f1 should only have 4 elements.
> Replace IPX_NODE_LEN with 4. In the while, remove the excess spaces
> before the fields of the union.
>
> Fixes: 56febcc2595e ("staging: r8188eu: Fix different base types in assignments and parameters")

Ugh... I really feel we'd be better off reverting that patch entirely.

regards,
dan carpenter