Re: [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs
From: Bjorn Andersson
Date: Tue Aug 03 2021 - 19:30:45 EST
On Thu 25 Feb 15:36 CST 2021, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
I noticed that this has not been picked up yet.
As changes to these files typically goes through the respective
maintainer's tree I think it would be good if you pick up the acks and
Also patch 1 and 2 has no real relationship, and per above request would
be picked by two different maintainers, so please post them separately
PS. I merged the Tone dts using the strings instead of the defines
(which I still prefer over using these defines).
> include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> index 32e66ee7e830..3cdca7ee1b3f 100644
> --- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> +++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> @@ -98,6 +98,9 @@
> /* To be used with "function" */
> #define PMIC_MPP_FUNC_NORMAL "normal"
> #define PMIC_MPP_FUNC_PAIRED "paired"
> +#define PMIC_MPP_FUNC_DIGITAL "digital"
> +#define PMIC_MPP_FUNC_ANALOG "analog"
> +#define PMIC_MPP_FUNC_SINK "sink"
> #define PMIC_MPP_FUNC_DTEST1 "dtest1"
> #define PMIC_MPP_FUNC_DTEST2 "dtest2"
> #define PMIC_MPP_FUNC_DTEST3 "dtest3"