Re: [PATCH v1 1/5] serdev: Split and export serdev_acpi_get_uart_resource()
From: Andy Shevchenko
Date: Wed Aug 04 2021 - 08:07:26 EST
On Wed, Aug 04, 2021 at 10:08:01AM +0200, Hans de Goede wrote:
> On 8/3/21 9:29 PM, Andy Shevchenko wrote:
> > The same as for I²C Serial Bus resource split and export
> > serdev_acpi_get_uart_resource(). We have already 3 users
> > one of which is converted here.
> > Rationale of this is to consolidate parsing UART Serial Bus
> > resource in one place as it's done, e.g., for I²C Serial Bus.
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Thanks, patch looks good to me:
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> *for this patch*
> We do need to talk about how to merge this series, I've
> NACK-ed patches 3/5 and 4/5 (see my reply there) so that
> leaves just 2/5 as depending on this one. I believe it
> would be easiest to just merge 1/5 + 2/5 to the tree
> which caries serdev patches, which I guess is Greg's
> tty tree ?
I can resend a v2 with tags and dropped mentioned patches.
I think it will be easier to everyone to handle.
With Best Regards,