Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent

From: Chao Yu
Date: Wed Aug 04 2021 - 23:15:12 EST


On 2021/8/5 11:04, Chao Yu wrote:
On 2021/8/5 10:53, Jaegeuk Kim wrote:
On 08/05, Chao Yu wrote:
Jaegeuk,

On 2021/8/5 7:45, Jaegeuk Kim wrote:
Chao,

How about this?
https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0

Looks more clean, thanks,


I'm digging one bug in __insert_extent_tree w/ the patch tho.

Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
__try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
w/ uninitialized c_len of @ei.

Fixed some bugs, but still getting another data corruption.

You mean data readed indexed by extent cache is inconsistent with the on-disk one,
right?

Thanks,


https://github.com/jaegeuk/f2fs/commit/c5d97919c55b467392407b60c1a7b1e3e81721ff

Let me rebase to your code, and do some tests.

Thanks



On 08/04, Chao Yu wrote:
+ if (from_dnode)
+ goto skip_reading_dnode;

Wrong condition here, thanks for fixing.

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel