Re: [PATCH] mfd: Don't use irq_create_mapping() to resolve a mapping

From: Lee Jones
Date: Thu Aug 05 2021 - 07:41:35 EST


On Sun, 25 Jul 2021, Marc Zyngier wrote:

> Although irq_create_mapping() is able to deal with duplicate
> mappings, it really isn't supposed to be a substitute for
> irq_find_mapping(), and can result in allocations that take place
> in atomic context if the mapping didn't exist.
>
> Fix the handful of MFD drivers that use irq_create_mapping() in
> interrupt context by using irq_find_mapping() instead.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> ---
> drivers/mfd/ab8500-core.c | 2 +-
> drivers/mfd/stmpe.c | 4 ++--
> drivers/mfd/tc3589x.c | 2 +-
> drivers/mfd/wm8994-irq.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog