Re: [PATCH] x86/Hyper-V: Initialize Hyper-V stimer after enabling lapic

[Tianyu Lan]

Hi Praveen:
    Thanks for your review.

On 8/5/2021 2:41 PM, Praveen Kumar wrote:
> > +
> > +static void __init hv_setup_initr_mode(void)
> > +{
> > +	if (old_setup_initr_mode)
> > +		old_setup_initr_mode();
> > +
> > +	/*
> > +	 * The direct-mode STIMER depends on LAPIC and so allocate
> > +	 * STIMER after calling initr node callback.
> > +	 */
> > +	(void)hv_stimer_alloc(false);
> In my understanding, in previous implementation we were ignoring the return error as there was a fallback handling for LAPIC.
> However, I'm not seeing the same here, or am I missing something ?

Nice catch. The original comment should be keep and will add back in the 
next version.