Re: [PATCH] tools/virtio: use 'unsigned int' instead of bare 'unsigned'

From: Michael S. Tsirkin
Date: Thu Aug 05 2021 - 18:15:25 EST


On Thu, Jul 29, 2021 at 08:04:02AM +0800, Jason Wang wrote:
> Replace the lazy way 'unsigned' with 'unsigned int' which is more
> accurate.
>
> Signed-off-by: Jason Wang <wangborong@xxxxxxxxxx>

I don't see why this is more accurate. AFAIK it's exactly the same.

> ---
> tools/virtio/vringh_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> index fa87b58bd5fa..3e85f4ec210d 100644
> --- a/tools/virtio/vringh_test.c
> +++ b/tools/virtio/vringh_test.c
> @@ -447,7 +447,7 @@ int main(int argc, char *argv[])
> char buf[28];
> u16 head;
> int err;
> - unsigned i;
> + unsigned int i;
> void *ret;
> bool (*getrange)(struct vringh *vrh, u64 addr, struct vringh_range *r);
> bool fast_vringh = false, parallel = false;
> @@ -654,7 +654,7 @@ int main(int argc, char *argv[])
>
> /* Free those buffers. */
> for (i = 0; i < RINGSIZE; i++) {
> - unsigned len;
> + unsigned int len;
> assert(virtqueue_get_buf(vq, &len) != NULL);
> }
>
> --
> 2.32.0